OCPEDGE-1192: feat: initial arbiter node addition #1731
Conversation
added support for creating install for clusters with arbiter nodes Signed-off-by: ehila <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @eggfoobar. Thanks for your PR. I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Currently running int an odd issue where I'm not sure if it's a problem with the devscript or not. But the arbiter node takes around 10minutes to join the cluster because the inspecting phase takes too long. @zaneb Would you be able to know why that is? I did create this PR in baremetal for the provisioning controller, but don't if I'm missing something else here. openshift/cluster-baremetal-operator#460 |
openshift-ci
bot
added
the
do-not-merge/hold
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
No idea about the inspection thing. Creating a new node type and duplicating all of the config for it seems like a... high-maintenance way to do this. Couldn't we treat the arbiter node as a control-plane node everywhere except when generating the install config? |
| @@ -136,6 +136,7 @@ ansible-playbook \ | |||
| -e "baremetal_network_name=${BAREMETAL_NETWORK_NAME}" \ | |||
| -e "working_dir=$WORKING_DIR" \ | |||
| -e "num_masters=$NUM_MASTERS" \ | |||
| -e "num_arbiters=$NUM_ARBITERS" \ | |||
There was a problem hiding this comment.
The playbook we're using here comes from https://github.com/metal3-io/metal3-dev-env/ which is an upstream project and thus does not (and can not) know about OCP-specific node types.
added support for creating install for clusters with arbiter nodes
In 4.19 of OCP, we will be supporting a deployment with Two Node Openshift with Arbiter on the baremetal platform, this PR adds the arbiter configuration to the metal scripts to help deploy and test arbiter topologies for baremetal.
For more details see EP: openshift/enhancements#1674